Open
Conversation
Owner
|
Probably need to bump zig on CI as well: zig-version: ['0.15.1'] |
- build.zig: moved link_libcpp to module creation and linkLibrary to module-level calls + std.Io related changes - std.Io: replaced std.io.FixedBufferStream with std.Io.Writer/Reader, updated Buffer.stream() to separate writer()/reader() methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had to do a couple of small fixes when updating a personal project to 0.16 in preparation for the upcoming release.
Decided I might as well create a PR for it in case it's of any interest 😃
Changes
build.zig:link_libcppandlinkLibrarymoved to module-levelsrc/Lua.zig: Replacedstd.io.FixedBufferStreamwithstd.Io.Writer/std.Io.Reader, updatedBuffer.stream()to separatewriter()/reader()methodssrc/tests.zig: Updated tests forstd.IocompatibilityThe
std.io.FixedBufferStreamchange is where there might be some contention on how it looks user-side, I decided to just go with the std's pattern instd.Io.Fileof using aWriterandReaderwith direct manipulation of the indices.