Skip to content

fix(audit): deep whole-repo hardening (20260228-073529) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndycode wants to merge 2 commits into from
Closed

fix(audit): deep whole-repo hardening (20260228-073529) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48eba3
fix(deps): patch hono and rollup audit findings
ndycode Feb 27, 2026
79a6d02
fix(auth): harden callback parsing and loopback redirect URI
ndycode Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
validate: (input: string): string | undefined => {
const parsed = parseAuthorizationInput(input);
if (!parsed.code) {
return "No authorization code found. Paste the full callback URL (e.g., http://localhost:1455/auth/callback?code=...)";
return `No authorization code found. Paste the full callback URL (e.g., ${REDIRECT_URI}?code=...)`;
}
if (!parsed.state) {
return "Missing OAuth state. Paste the full callback URL including both code and state parameters.";
Expand Down
6 changes: 5 additions & 1 deletion lib/auth/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { safeParseOAuthTokenResponse } from "../schemas.js";
export const CLIENT_ID = "app_EMoamEEZ73f0CkXaXp7hrann";
export const AUTHORIZE_URL = "https://auth.openai.com/oauth/authorize";
export const TOKEN_URL = "https://auth.openai.com/oauth/token";
export const REDIRECT_URI = "http://localhost:1455/auth/callback";
export const REDIRECT_URI = "http://127.0.0.1:1455/auth/callback";
export const SCOPE = "openid profile email offline_access";

/**
Expand Down Expand Up @@ -44,6 +44,10 @@ export function parseAuthorizationInput(input: string): ParsedAuthInput {
if (code || state) {
return { code, state };
}

// Input is a valid URL but does not contain OAuth parameters.
// Do not reinterpret URL fragments as "code#state" fallback syntax.
return {};
} catch {
// Invalid URL, try other parsing methods
}
Expand Down
Loading