Skip to content

fix: always add the url to json output#7738

Open
minivan wants to merge 6 commits intomainfrom
minivan/fix-astro-feedback
Open

fix: always add the url to json output#7738
minivan wants to merge 6 commits intomainfrom
minivan/fix-astro-feedback

Conversation

@minivan
Copy link
Copy Markdown
Contributor

@minivan minivan commented Oct 23, 2025

When we removed the --prod as a requirement from the ntl build command, there's a check we missed. It's useful to see the url for deploys.

@minivan minivan requested a review from a team as a code owner October 23, 2025 15:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 23, 2025

📊 Benchmark results

Comparing with 803c6ae

  • Dependency count: 1,052 (no change)
  • Package size: 317 MB ⬇️ 0.00% decrease vs. 803c6ae
  • Number of ts-expect-error directives: 366 (no change)

VitaliyR
VitaliyR previously approved these changes Oct 23, 2025
@minivan minivan enabled auto-merge (squash) October 23, 2025 15:59
serhalp
serhalp previously approved these changes Oct 23, 2025
Copy link
Copy Markdown
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/integration/commands/deploy/deploy.test.ts Outdated
@minivan minivan disabled auto-merge October 23, 2025 16:03
@minivan minivan dismissed stale reviews from serhalp and VitaliyR via f66b22b March 16, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants