ci: freeze legacy ExtJS assets static, drop the broken Encore build#431
Conversation
The legacy ExtJS Encore build (npm run build -> public/build) fails only in the GitHub-Actions buildkit env — the same npm ci + encore production compiles cleanly on the identical :e2e image locally — and it gates every open PR's CI. ExtJS is being removed shortly and its assets won't change, so commit the generated public/build as static files and retire the Encore build rather than chase a CI-only break: - commit public/build (un-ignored in .gitignore + .dockerignore) - Dockerfile: drop `npm run build`, keep the SolidJS Vite build - ci.yml: drop the "Build legacy ExtJS assets (Encore)" step The SolidJS UI (public/build-ui) is still built by Vite as before. This unblocks CI for all open PRs (#427, #429, #430 rebase onto this). Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request retires the Webpack Encore build for legacy ExtJS assets, committing them as static files under public/build/ instead. Consequently, public/build has been removed from .gitignore and .dockerignore, and the Dockerfile has been updated to only build the new SolidJS UI using Vite. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=========================================
Coverage 83.92% 83.92%
Complexity 2752 2752
=========================================
Files 187 187
Lines 7534 7534
=========================================
Hits 6323 6323
Misses 1211 1211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Unblocks CI for every open PR. The legacy ExtJS Encore build (
npm run build->public/build) fails only in the GitHub-Actions buildkit environment — the identical:e2eimage (node 24) runsnpm ci+encore productionto "Compiled successfully" locally, but the GHA build produces a broken@symfony/webpack-encore. It's not the cli version, node version, lock, ornpm ci(all ruled out), and it gates the build jobs that every PR depends on.ExtJS is being removed shortly and its built assets won't change, so per maintainer call we freeze them static and retire the Encore build:
public/build(un-ignored in.gitignore+.dockerignore)Dockerfile: dropnpm run build, keep the SolidJSbun run --cwd frontend buildci.yml: drop the "Build legacy ExtJS assets (Encore)" stepThe SolidJS UI (
public/build-ui) is still built by Vite. This PR's own CI passing is the validation. Once merged, #427/#429/#430 rebase onto it and go green.Note: +30 MB of committed static assets (the ExtJS SDK) — accepted as a short-term measure since the ExtJS removal will delete them.