Skip to content

SessionStorage::setupExpiration() nette/http v3.4.0 compatibility#77

Open
forgie1 wants to merge 1 commit into
nette:masterfrom
forgie1:v3.2
Open

SessionStorage::setupExpiration() nette/http v3.4.0 compatibility#77
forgie1 wants to merge 1 commit into
nette:masterfrom
forgie1:v3.2

Conversation

@forgie1

@forgie1 forgie1 commented Jun 14, 2026

Copy link
Copy Markdown

Closes #76

@becygroup

Copy link
Copy Markdown

It is not enough. Even the expiration is provided, needs to be converted to relative from absolute timestamp.

nette/security/src/Bridges/SecurityHttp/SessionStorage.php:73:

$this->expireTime = $time ? (int) Nette\Utils\DateTime::from($time)->format('U') : null;

Needs to be converted to relative time when section expiration is set in

nette/security/src/Bridges/SecurityHttp/SessionStorage.php:94

$section->setExpiration((string) ($this->expireTime - time()), 'foo'); // time check

or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.2.4 is not compatible with nette/http v3.4.0

2 participants