Refactor provider to use OpenAI parser as a fallback and enhance test…#376
Open
Refactor provider to use OpenAI parser as a fallback and enhance test…#376
Conversation
…s for processor behavior
jvanderaa
requested review from
glennmatthews,
pke11y and
scetron
as code owners
|
|
||
| # Use OpenAI parser as a last resort if all other processors failed. | ||
| if os.getenv("PARSER_OPENAI_API_KEY"): | ||
| self.add_subject_to_text(data) |
Contributor
There was a problem hiding this comment.
Still feels like modifying data in place may lead to bugs in the future. Might be better to change add_subject_to_text(data) so that it returns a modified copy instead of modifying the original in place?
Contributor
Author
There was a problem hiding this comment.
I think we should be good here, this is the last point in the path. Everything should be sent in and should be kept outside of the parsers.
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
…de/circuit-maintenance-parser into 372-fix_openain_iCal
Contributor
Author
|
Fixes #372 |
glennmatthews
approved these changes
Feb 20, 2026
|
|
||
| def test_provider_data_not_mutated_when_native_succeeds(): | ||
| """Test that add_subject_to_text is not called when native processors succeed.""" | ||
| os.environ["PARSER_OPENAI_API_KEY"] = "some_api_key" |
Contributor
There was a problem hiding this comment.
Can we change all of these test cases to use patch.dict(os.environ, ...) as was done for test_provider_falls_back_to_openai above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s for processor behavior
Fix for the process of the OpenAI fallback to being a fallback. Includes a modification to not change the ical data.