-
-
Notifications
You must be signed in to change notification settings - Fork 420
Python helper scripts: fix deprecation warning #3256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DeprecationWarning: codecs.open() is deprecated. Use open() instead. Signed-off-by: Paul Donald <newtwen+github@gmail.com>
|
Thanks, this seems like it should work with pythons we care about in legacy OS practice (2.6+ and 3.x), but I'll let the multiplatform CI say if this change is OK ir needs if/else try/except etc. sort of handling. |
|
So... more code is needed to make sure which python version we are running on (or just try/except for missing class properties or method signatures): |
…py.in: fix codecs.open() deprecation warning (3.14+) [networkupstools#3256] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com> Co-Authored-by: Paul Donald <newtwen+github@gmail.com>
…py.in: fix codecs.open() deprecation warning (3.14+) [networkupstools#3256] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com> Co-Authored-by: Paul Donald <newtwen+github@gmail.com>
|
Will be extended and addressed by #3300, thanks. |
…gs (e.g. DeprecationWarning) to use correct form of open() [networkupstools#3256] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…nclosed file descriptors [networkupstools#3256] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…g. DeprecationWarning) to use correct form of open() [networkupstools#3256] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
DeprecationWarning: codecs.open() is deprecated. Use open() instead.