-
-
Notifications
You must be signed in to change notification settings - Fork 420
Fix upsdrvctl for make check-NIT in MSYS2/WIN32 builds
#3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+62
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build nut 2.8.4.4144-master failed (commit 01401fac87 by @jimklimov) |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 1, 2026
…P_BUILDDIR separately from makefile abs_top_builddir [networkupstools#3294] The original hack broke the PATH parsing (added colons in WIN32 tests) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
2ec281e to
15cee54
Compare
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 2, 2026
…P_BUILDDIR separately from makefile abs_top_builddir [networkupstools#3294] The original hack broke the PATH parsing (added colons in WIN32 tests) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.4.4157-master failed (commit daa8aa4d65 by @jimklimov) |
…etworkupstools#2800] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…sted spelling of ABS_TOP_SRCDIR and ABS_TOP_BUILDDIR so it ends up in "driverpath" correctly for WIN32 builds [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… not only quoted but also with escaped backslashes [networkupstools#3292] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…P_BUILDDIR separately from makefile abs_top_builddir [networkupstools#3294] The original hack broke the PATH parsing (added colons in WIN32 tests) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…verpath uses them [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
15cee54 to
b4ca684
Compare
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
…path uses them [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
…s() for the driver in build workspace, not only in final installation [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
…path uses them [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 4, 2026
…s() for the driver in build workspace, not only in final installation [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
b4ca684 to
7d0efe2
Compare
|
❌ Build nut 2.8.4.4187-master failed (commit a19f9d82e4 by @jimklimov) |
…path uses them [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s() for the driver in build workspace, not only in final installation [networkupstools#3294] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
7d0efe2 to
d857389
Compare
|
✅ Build nut 2.8.4.4188-master completed (commit 9d24b30e4b by @jimklimov) |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
…mmandline [networkupstools#3294, networkupstools#3305] Closes: networkupstools#3305 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
…mmandline [networkupstools#3294, networkupstools#3305] Closes: networkupstools#3305 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
…mmandline [networkupstools#3294, networkupstools#3305] Closes: networkupstools#3305 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes)
portability
We want NUT to build and run everywhere possible
Windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3292 trying to make
upsdrvctlusable formake check-NITin MSYS2 semi-native Windows builds (e.g. Appveyor CI).