PEP8 cleanup.

[Cabalist]

PEP8. Updated code to be more compliant with Python3. Renamed a couple things that were colliding with reserved kws. Use "in" instead of ".has_key()"

The app has dependencies on an older GTK library that will take some time to replace. I am submitting this pull request as laying the groundwork for that cleanup. Thanks!

[clepple]

Sorry I haven't had a chance to look at this until now. I just checked out this branch on Debian stretch, and did a quick regression test using Python 2.7. Relative to the NUT-Monitor script in stretch (from NUT 2.7.4), your changes do not seem to allow saving favorites. Let me know if you need an exact traceback, but I think it had a problem trying to save the False boolean value to "auth" - something about values only being strings.

[jimklimov]

A few merge conflicts cropped up :(

[jimklimov]

I fixed the merge conflicts to make this PR applicable to master, to the best of my understanding of the script (in particular, there was a bit about renaming the variables to avoid reserved key words).

Still, marked as "Needs testing" to have someone check the GUI tool changes before merging.

CC @melenki as a recent contributor to NUT-Monitor area: Alexey, would you please have a chance to revise this PR and test its version of the scripts on a GUI workstation to make sure stuff still works? ;)

[lgtm-com]

This pull request fixes 2 alerts when merging f8374c0 into 52df79c - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unused import

[melenki]

[...]

CC @melenki as a recent contributor to NUT-Monitor area: Alexey, would you please have a chance to revise this PR and test its version of the scripts on a GUI workstation to make sure stuff still works? ;)

Since the patch was published, the Python version has changed, and so has the ABI.
NUT-Monitor does not start after applying the patch. A number of language constructs for Python versions 3.6/3.8 require refactoring. For example, the method 'glade' is not present in the Gtk module for Python3.

To fully meet the requirements of Python 3.x, a patch needs to be reworking.

[lgtm-com]

This pull request fixes 2 alerts when merging 73efe9c into 8e86544 - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unused import

[jimklimov]

Note regarding comment for Python 3: it is a different language than Python 2 :)

That said, several layers of PRs were made to make some code dually supported on both, and reimplement the GUI for the new tech, e.g. #1310