Skip to content

fix(gallery): video thumbnail and overlay#16708

Open
alperozturk96 wants to merge 3 commits intomasterfrom
fix/video-icon-thumbnail
Open

fix(gallery): video thumbnail and overlay#16708
alperozturk96 wants to merge 3 commits intomasterfrom
fix/video-icon-thumbnail

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 19, 2026

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20260319_155202 Screenshot_20260319_155139

Uses PREFIX_THUMBNAIL for videos.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16708.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 26, 2026
}

private fun getVideoBitmap(file: OCFile, onThumbnailGeneration: () -> Unit): Bitmap? {
val key = ThumbnailsCacheManager.PREFIX_THUMBNAIL + file.remoteId
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREFIX_RESIZED_IMAGE for aspect aware ratio, if downloaded

onThumbnailGeneration()
var bitmap: Bitmap? = null
if (file.isDown) {
bitmap = createVideoThumbnail(file.storagePath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create here a aspect ratio aware one
-> in oc file list fragment -> use thumbnail (square) with PREFIX_THUMBNAIL

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/video-icon-thumbnail branch from bf835b4 to 249cd65 Compare March 26, 2026 12:47
@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice3939
Correctness7070
Dodgy code236236
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1717
Total448448

@github-actions
Copy link

APK file: https://github.com/nextcloud/android/actions/runs/23595097214/artifacts/6123562074
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants