Skip to content

fix(auto-upload): clean stale upload entities#16712

Open
alperozturk96 wants to merge 8 commits intomasterfrom
fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled
Open

fix(auto-upload): clean stale upload entities#16712
alperozturk96 wants to merge 8 commits intomasterfrom
fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 20, 2026

Issue

When a synced folder is disabled or deleted, its associated OCUpload entries in the uploads
table must be cleaned up. Without this, stale upload entries outlive the folder config that
created them, causing FileUploadWorker to keep retrying uploads for a folder that no longer
exists or is intentionally turned off, and AutoUploadWorker to re-queue already handled files
on its next scan via FileSystemRepository.getFilePathsWithIds.

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 20, 2026
@github-actions
Copy link

github-actions bot commented Mar 20, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23338813176/artifacts/6023879981
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23340161367/artifacts/6024223748
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky
tobiasKaminsky previously requested changes Mar 26, 2026
View reviewed changes
@alperozturk96 alperozturk96 force-pushed the fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled branch from bd358dd to cf352c1 Compare March 26, 2026 10:33
@github-actions
Copy link

github-actions bot commented Mar 26, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23589729348/artifacts/6121126347
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(auto-upload): clean stale upload entities
020457e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): clean stale upload entities
5d00ccc 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): clean stale upload entities
877d53f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/nextcloud/client/database/dao/FileSystemDao.kt
@alperozturk96
fix(auto-upload): clean stale upload entities
f2d01a8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): clean stale upload entities when user delete auto u…
8a2e270 
…pload folder

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add dao funcs
acbb113 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add onAutoUploadFolderRemoved
841c178 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled branch from 98ef76d to 841c178 Compare March 26, 2026 11:54
@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Mar 26, 2026 •
edited
Loading

@tobiasKaminsky

Screenshot_20260326_124941

@github-actions
Copy link

github-actions bot commented Mar 26, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23592927079/artifacts/6122748899
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
allow user to delete normal files together with auto upload folders
26eb15a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Mar 26, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Mar 26, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3939
Correctness7070
Dodgy code236236
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1717
Total448448

@github-actions
Copy link

github-actions bot commented Mar 26, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23594975309/artifacts/6123530655
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review feature: auto upload

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky