Skip to content

fix(oc-file-list): favorite refresh#17018

Open
alperozturk96 wants to merge 10 commits into
masterfrom
fix/oc-file-list-favorite-refresh
Open

fix(oc-file-list): favorite refresh#17018
alperozturk96 wants to merge 10 commits into
masterfrom
fix/oc-file-list-favorite-refresh

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented May 8, 2026 •
edited
Loading

Issue

Duplicated items is displayed after rename favorite file

Steps to reproduce

  1. Mark file as favorite
  2. Open favorite tab
  3. Rename favorite file

Changes

  • Fixes the issue by always setting up-to-date cached then remote files properly
  • Fixes refresh after rename
  • Fixes refresh after delete
  • Fixes resetting layout after rename
  • Fixes loading state after rename for search task
  • Simplifies rename logic via early exits and separate functions
  • Add comments to understand flow better

@alperozturk96 alperozturk96 marked this pull request as draft May 8, 2026 13:59
@alperozturk96 alperozturk96 added the ux-enhancement Improvements that refine user interactions, accessibility, or overall usability label May 11, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.1 milestone May 11, 2026
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented May 11, 2026

/backport to stable-33.1.x

alperozturk96
alperozturk96 commented May 11, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
}

val file = storageManager.getFileById(renamedFile.parentId)
if (file != null && file == getCurrentDir()) {
Copy link
Copy Markdown
Collaborator Author

@alperozturk96 alperozturk96 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (file != null && file == getCurrentDir()) {

Is there any reason to use this condition here @tobiasKaminsky ?

Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it, yes. If e.g. someone renames a file and directly navigates to another folder.
then we do not need to refresh the other folder.

@alperozturk96 alperozturk96 marked this pull request as ready for review May 11, 2026 07:42
@alperozturk96 alperozturk96 force-pushed the fix/oc-file-list-favorite-refresh branch from 769f480 to a8abad5 Compare May 11, 2026 07:42
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25664115298/artifacts/6916208022
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(oc-file-list): favorite refresh
c89d5e2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refresh directory to always use latest cached files to prevent duplic…
f5a5950 
…ate item

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
only show loading state first time if app doesn't have active search …
999ae34 
…task

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refresh current dir was not mandatory
cab8e86 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
resolveLocalFileId instead refresh whole directory
3709338 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
simplify on rename logics
1895aec 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix refresh after rename
ad0cfb8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix codacy
1d72739 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix delete file refresh
cc97f6b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/oc-file-list-favorite-refresh branch from 35b9cdd to cc97f6b Compare May 11, 2026 13:30
@alperozturk96
keep layout style after rename
a3b17e3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420420

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25673926941/artifacts/6920944020
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky
tobiasKaminsky requested changes May 13, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/client/preferences/AppPreferencesImpl.java

@Override
public String getFolderLayout(OCFile folder) {
public String getFolderLayout(OCFile folder, String defaultLayout) {
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adopt to use it like in " setSortOrder(FileSortOrder.Type type"

tobiasKaminsky
tobiasKaminsky requested changes May 13, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
}

val file = storageManager.getFileById(renamedFile.parentId)
if (file != null && file == getCurrentDir()) {
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it, yes. If e.g. someone renames a file and directly navigates to another folder.
then we do not need to refresh the other folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

backport-request ux-enhancement Improvements that refine user interactions, accessibility, or overall usability

Projects

None yet

Milestone

Nextcloud App 33.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky