Skip to content

fix(semantic): improve HTML semantics across templates#1721

Merged
edward-ly merged 1 commit intomasterfrom
fix/noid/semantic-html-fixes
Mar 26, 2026
Merged

fix(semantic): improve HTML semantics across templates#1721
edward-ly merged 1 commit intomasterfrom
fix/noid/semantic-html-fixes

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Mar 11, 2026

  • Replace navbar-default class on <footer> with site-footer
  • Extract filter form out of <ul class="nav-tabs"> into its own sibling element
  • Convert .app-meta <div> to <aside aria-label="App information"> on detail page
  • Merge duplicate {% if request.user.is_authenticated %} blocks in nav.html

Copy link
Copy Markdown
Collaborator

@edward-ly edward-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good apart from one breaking change: while it might make sense to add more visual separation the sort and filter options, there seems to be an issue with the flex layout for the sorting options on smaller screens.

Here's what the options row look like on the master branch.
Image

And here's what the PR changes look like on the same screen. The rating sort is not accessible anymore, in this case.
Image

Make sure the options row remain responsive to the screen width (preferably by restoring the wrapping behavior, but if you have a better solution, I'm all ears).

@miaulalala miaulalala force-pushed the fix/noid/semantic-html-fixes branch from b756dfe to 5b5cbc6 Compare March 23, 2026 08:32
@edward-ly
Copy link
Copy Markdown
Collaborator

Hm, at certain screen widths (around 993 to 1998 px), there is quite a bit of empty space between the sort and filter options, to the point where it might look better if the filter options were collapsed into the end of the second line rather than be on its own line, in this case. Would you agree, or is there a reason why this layout might be preferred?

Screenshot 2026-03-23 at 16-30-31 All apps - App Store - Nextcloud

@miaulalala miaulalala force-pushed the fix/noid/semantic-html-fixes branch 2 times, most recently from 9ec1ce8 to 8d25b1e Compare March 26, 2026 11:07
@miaulalala miaulalala requested a review from edward-ly March 26, 2026 11:39
Signed-off-by: Anna Larch <anna@nextcloud.com>
@edward-ly edward-ly force-pushed the fix/noid/semantic-html-fixes branch from 8d25b1e to 16f79e8 Compare March 26, 2026 15:16
Copy link
Copy Markdown
Collaborator

@edward-ly edward-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Rebased branch and resolved a small conflict. Failing tests are unrelated and will be resolved separately.

@edward-ly edward-ly merged commit a0bb0b9 into master Mar 26, 2026
6 of 8 checks passed
@edward-ly edward-ly deleted the fix/noid/semantic-html-fixes branch March 26, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants