fix(semantic): improve HTML semantics across templates#1721
Conversation
edward-ly
left a comment
There was a problem hiding this comment.
Everything looks good apart from one breaking change: while it might make sense to add more visual separation the sort and filter options, there seems to be an issue with the flex layout for the sorting options on smaller screens.
Here's what the options row look like on the master branch.

And here's what the PR changes look like on the same screen. The rating sort is not accessible anymore, in this case.

Make sure the options row remain responsive to the screen width (preferably by restoring the wrapping behavior, but if you have a better solution, I'm all ears).
b756dfe to
5b5cbc6
Compare
9ec1ce8 to
8d25b1e
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
8d25b1e to
16f79e8
Compare
edward-ly
left a comment
There was a problem hiding this comment.
🚀 Rebased branch and resolved a small conflict. Failing tests are unrelated and will be resolved separately.

<footer>with site-footer<ul class="nav-tabs">into its own sibling element<div>to<aside aria-label="App information">on detail page{% if request.user.is_authenticated %}blocks in nav.html