-
Notifications
You must be signed in to change notification settings - Fork 337
🕵️ Add sharereview support #8052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AndyScherzinger
wants to merge
8
commits into
main
Choose a base branch
from
feat/noid/sharereview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e9213e0
feat(sharereview): add listener registering Deck as a share source
AndyScherzinger 0913702
feat(sharereview): add ShareReviewSource with constructor and getName()
AndyScherzinger 9f7284c
feat(sharereview): implement getShares() with board name lookup via JOIN
AndyScherzinger 162414a
feat(sharereview): implement deleteShare() via direct SQL with logging
AndyScherzinger 8620aa3
feat(sharereview): register ShareReview listener on SourceEvent
AndyScherzinger babbc69
style(sharereview): apply coding standards and Psalm fixes
AndyScherzinger b12ac74
test(sharereview): add unit tests for ShareReviewSource
AndyScherzinger 957ce8d
fix(sharereview): harden and optimize implementation and testing
AndyScherzinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\Deck\ShareReview; | ||
|
|
||
| use OCA\ShareReview\Sources\SourceEvent; | ||
| use OCP\EventDispatcher\Event; | ||
| use OCP\EventDispatcher\IEventListener; | ||
|
|
||
| /** @template-implements IEventListener<SourceEvent> */ | ||
| class ShareReviewListener implements IEventListener { | ||
| public function __construct() { | ||
| } | ||
|
|
||
| public function handle(Event $event): void { | ||
| if (!$event instanceof SourceEvent) { | ||
| return; | ||
| } | ||
| $event->registerSource(ShareReviewSource::class); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\Deck\ShareReview; | ||
|
|
||
| use OCA\Deck\Db\Acl; | ||
| use OCA\ShareReview\Sources\ISource; | ||
| use OCP\Constants; | ||
| use OCP\DB\Exception; | ||
| use OCP\DB\QueryBuilder\IQueryBuilder; | ||
| use OCP\IDBConnection; | ||
| use OCP\Share\IShare; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| class ShareReviewSource implements ISource { | ||
|
|
||
| private const ACL_TABLE = 'deck_board_acl'; | ||
| private const BOARDS_TABLE = 'deck_boards'; | ||
| private const PERMISSION_MANAGE = 32; | ||
|
|
||
| public function __construct( | ||
| private IDBConnection $db, | ||
| private LoggerInterface $logger, | ||
| ) { | ||
| } | ||
|
|
||
| public function getName(): string { | ||
| return 'Deck'; | ||
| } | ||
|
|
||
| /** | ||
| * @return list<array{id: int, app: string, object: string, initiator: string, type: int, recipient: string, permissions: int, password: bool, time: string, action: string}> | ||
| */ | ||
| public function getShares(): array { | ||
| $rawShares = $this->fetchAllShares(); | ||
| $appName = $this->getName(); | ||
| $formatted = []; | ||
| foreach ($rawShares as $share) { | ||
| $formatted[] = [ | ||
| 'id' => (int)$share['id'], | ||
| 'app' => $appName, | ||
| 'object' => $this->resolveObjectName($share), | ||
| 'initiator' => (string)$share['board_owner'], | ||
| 'type' => $this->mapParticipantType((int)$share['type']), | ||
| 'recipient' => (string)$share['participant'], | ||
| 'permissions' => $this->computePermissions($share), | ||
| 'password' => false, | ||
| 'time' => '1970-01-01 01:00:00', | ||
| 'action' => '', | ||
| ]; | ||
| } | ||
| return $formatted; | ||
| } | ||
|
|
||
| public function deleteShare(string $shareId): bool { | ||
| $this->logger->info('Deck ShareReview: deleting share {id}', ['id' => $shareId]); | ||
| try { | ||
| $qb = $this->db->getQueryBuilder(); | ||
| $qb->delete(self::ACL_TABLE) | ||
| ->where($qb->expr()->eq('id', $qb->createNamedParameter((int)$shareId, IQueryBuilder::PARAM_INT))); | ||
| return $qb->executeStatement() > 0; | ||
| } catch (Exception $e) { | ||
| $this->logger->error('Deck ShareReview: failed to delete share {id}: {message}', ['id' => $shareId, 'message' => $e->getMessage()]); | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| /** @return list<array<string, mixed>> */ | ||
| private function fetchAllShares(): array { | ||
| try { | ||
| $qb = $this->db->getQueryBuilder(); | ||
| $qb->select( | ||
| 'a.id', 'a.board_id', 'a.type', 'a.participant', | ||
| 'a.permission_edit', 'a.permission_share', 'a.permission_manage' | ||
| ) | ||
| ->selectAlias('b.title', 'board_title') | ||
| ->selectAlias('b.owner', 'board_owner') | ||
| ->from(self::ACL_TABLE, 'a') | ||
| ->leftJoin('a', self::BOARDS_TABLE, 'b', $qb->expr()->eq('a.board_id', 'b.id')) | ||
| ->orderBy('a.id', 'ASC'); | ||
| $result = $qb->executeQuery(); | ||
| $rows = $result->fetchAll(); | ||
| $result->closeCursor(); | ||
| return $rows; | ||
| } catch (Exception $e) { | ||
| $this->logger->error('Deck ShareReview: failed to fetch shares: {message}', ['message' => $e->getMessage()]); | ||
| return []; | ||
| } | ||
| } | ||
|
|
||
| /** @param array<string, mixed> $share */ | ||
| private function resolveObjectName(array $share): string { | ||
| $title = (string)($share['board_title'] ?? ''); | ||
| $boardId = (int)($share['board_id'] ?? $share['id']); | ||
| return ($title !== '' ? $title : "Board $boardId") . ' (Board)'; | ||
| } | ||
|
|
||
| private function mapParticipantType(int $type): int { | ||
| return match($type) { | ||
| Acl::PERMISSION_TYPE_USER => IShare::TYPE_USER, | ||
| Acl::PERMISSION_TYPE_GROUP => IShare::TYPE_GROUP, | ||
| Acl::PERMISSION_TYPE_REMOTE => IShare::TYPE_REMOTE, | ||
| Acl::PERMISSION_TYPE_CIRCLE => IShare::TYPE_CIRCLE, | ||
| default => IShare::TYPE_USER, | ||
| }; | ||
| } | ||
|
|
||
| /** @param array<string, mixed> $share */ | ||
| private function computePermissions(array $share): int { | ||
| $permissions = Constants::PERMISSION_READ; | ||
| if ($share['permission_edit']) { | ||
| $permissions |= Constants::PERMISSION_UPDATE | Constants::PERMISSION_CREATE | Constants::PERMISSION_DELETE; | ||
| } | ||
| if ($share['permission_share']) { | ||
| $permissions |= Constants::PERMISSION_SHARE; | ||
| } | ||
| if ($share['permission_manage']) { | ||
| $permissions |= self::PERMISSION_MANAGE; | ||
| } | ||
| return $permissions; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems we do not have a creation/modification date of share records
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified, no creation/modification metadata present