ci: automate upgrade testing#1019
Open
nabim777 wants to merge 7 commits into
Open
Conversation
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
2 times, most recently
from
b714a55 to
48467b1
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
from
48467b1 to
2771035
Compare
PHP Code CoverageCoverage after merging upgrade-testing-local-setup into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
4 times, most recently
from
69ffef9 to
6b30af6
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
5 times, most recently
from
9ecc483 to
b85fe46
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
3 times, most recently
from
97a83af to
64f2bab
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
3 times, most recently
from
f5123d9 to
13059b1
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
from
13059b1 to
3234322
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
upgrade-testing-local-setup
branch
from
e7f22dd to
c696b82
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
requested review from
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
Collaborator
Author
|
question is: |
saw-jan
reviewed
May 14, 2026
Comment on lines
+1
to
+8
| # This workflow is provided via the organization template repository | ||
| # | ||
| # https://github.com/nextcloud/.github | ||
| # https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization | ||
|
|
||
| # SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org> | ||
| # | ||
| # SPDX-License-Identifier: CC0-1.0 |
Collaborator
There was a problem hiding this comment.
Suggested change
| # This workflow is provided via the organization template repository | |
| # | |
| # https://github.com/nextcloud/.github | |
| # https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization | |
| # SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org> | |
| # | |
| # SPDX-License-Identifier: CC0-1.0 | |
| # SPDX-FileCopyrightText: 2026 Jankari Tech Pvt. Ltd. | |
| # SPDX-License-Identifier: AGPL-3.0-or-later |
saw-jan
reviewed
May 14, 2026
Comment on lines
+1
to
+4
| # SPDX-FileCopyrightText: 2023-2024 Jankari Tech Pvt. Ltd. | ||
| # SPDX-FileCopyrightText: 2023 Bundesministerium des Innern und für Heimat, PG ZenDiS "Projektgruppe für Aufbau ZenDiS" | ||
| # SPDX-FileCopyrightText: 2023 Nextcloud GmbH | ||
| # SPDX-License-Identifier: AGPL-3.0-only |
Collaborator
There was a problem hiding this comment.
Suggested change
| # SPDX-FileCopyrightText: 2023-2024 Jankari Tech Pvt. Ltd. | |
| # SPDX-FileCopyrightText: 2023 Bundesministerium des Innern und für Heimat, PG ZenDiS "Projektgruppe für Aufbau ZenDiS" | |
| # SPDX-FileCopyrightText: 2023 Nextcloud GmbH | |
| # SPDX-License-Identifier: AGPL-3.0-only | |
| # SPDX-FileCopyrightText: 2026 Jankari Tech Pvt. Ltd. | |
| # SPDX-License-Identifier: AGPL-3.0-only |
saw-jan
reviewed
May 14, 2026
Comment on lines
+42
to
+43
| PREVIOUS_APP_VERSION: 2.9.2 | ||
| UPGRADE_APP_VERSION: 2.10.0 |
Collaborator
There was a problem hiding this comment.
we should install the current compatible app version without specifying the version.
The app version to upgrade should be greater than the current version.
saw-jan
reviewed
May 14, 2026
Comment on lines
+87
to
+89
| - name: Build nextcloud project | ||
| run: | | ||
| export DEBIAN_FRONTEND=noninteractive |
Collaborator
There was a problem hiding this comment.
can we start nextcloud in the service section?
saw-jan
reviewed
May 14, 2026
Comment on lines
+120
to
+151
| - name: Setup System dependencies for appstore | ||
| run: | | ||
| sudo apt install -y \ | ||
| python3-venv \ | ||
| python3-wheel \ | ||
| libxslt-dev \ | ||
| libxml2-dev \ | ||
| libz-dev \ | ||
| libpq-dev \ | ||
| build-essential \ | ||
| python3-dev \ | ||
| python3-setuptools \ | ||
| gettext \ | ||
| libssl-dev \ | ||
| libffi-dev \ | ||
| nodejs \ | ||
| yarn | ||
|
|
||
| - name: Checkout appstore | ||
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 | ||
| with: | ||
| repository: nextcloud/appstore | ||
| path: appstore | ||
|
|
||
| - name: Install Appstore | ||
| run: | | ||
| cd appstore | ||
| python3 -m venv venv | ||
| source venv/bin/activate | ||
| pip install poetry==1.8.2 | ||
| make dev-setup | ||
| python manage.py runserver & |
Collaborator
There was a problem hiding this comment.
hmm, maybe we should create custom minimal REST server as appstore
saw-jan
reviewed
May 14, 2026
Comment on lines
+58
to
+61
| with: | ||
| path: integration_openproject | ||
| fetch-tags: true | ||
| ref: v${{ env.UPGRADE_APP_VERSION }} |
Collaborator
There was a problem hiding this comment.
not sure about it. simply checkout the current source
individual-it
requested changes
May 14, 2026
Comment on lines
+84
to
+85
| coverage: xdebug | ||
| tools: php-cs-fixer, phpunit |
Collaborator
There was a problem hiding this comment.
do we need xdebug and the other tools?
|
|
||
| env: | ||
| DJANGO_SETTINGS_MODULE: nextcloudappstore.settings.development | ||
| PREVIOUS_APP_VERSION: 2.9.2 |
Collaborator
There was a problem hiding this comment.
that version should be found automatically. Just take the last released stable version.
Otherwise, there is one more place to remember to change version numbers.
individual-it
requested changes
May 14, 2026
Collaborator
individual-it
left a comment
individual-it
left a comment
There was a problem hiding this comment.
in the log output of the test run I see
Error response from daemon: No such container: nextcloud
what is that about? Kind of confusing to see this error.
| wget https://raw.githubusercontent.com/nextcloud/integration_openproject/${{github.head_ref}}/.github/scripts/self-hosted-app-store.sh | ||
| bash ./self-hosted-app-store.sh | ||
|
|
||
| - name: Enable other apps from official app store |
Collaborator
There was a problem hiding this comment.
this is not entirely true, because at least activity is cloned further up by git
| env: | ||
| APP_VERSION: ${{ env.UPGRADE_APP_VERSION }} | ||
| run: | | ||
| bash ./self-hosted-app-store.sh |
Collaborator
There was a problem hiding this comment.
the name of that bash file is confusing. It sounds as if it starts the app-store, but that is not true.
| cd ~/html/nextcloud | ||
| # latest data didn't get fetched properly, so we need to clear the appstore cache | ||
| echo "" > ~/html/nextcloud/data/appdata_*/appstore/apps.json | ||
| php occ app:update --allow-unstable integration_openproject |
Collaborator
There was a problem hiding this comment.
we should check whether the upgrade to the new version really happened
| --admin-user admin \ | ||
| --admin-pass admin | ||
| php occ maintenance:mode --off | ||
| sudo php -S localhost:80 -t ~/html/nextcloud & |
Collaborator
There was a problem hiding this comment.
it would be better to run NC with a real web-server like apache, but for now this should be fine
| - name: Check for Appstore | ||
| run: | | ||
| cd appstore | ||
| status=$(curl -o /dev/null -s -w "%{http_code}" http://localhost:8000) |
Collaborator
There was a problem hiding this comment.
that appstore URL could go into a variable, because it is used in a lot of places
| echo "FAILED (status: $status)" | ||
| fi | ||
|
|
||
| - name: Register and publish integration_openproject apps |
Collaborator
There was a problem hiding this comment.
the previous app version can be installed from the official app store. Just take the latest published stable version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an upgrade testing workflow.
It validates the full upgrade path by:
integration_openprojectapps from self-hosted app store.integration_openprojectapps from self-hosted app store.Tests run across multiple Nextcloud and PHP version combinations.
Available env:
NEXTCLOUD_VERSIONS: Nextcloud versions to test.
PHP_VERSIONS: PHP versions to test.
PREVIOUS_APP_VERSION: App version installed first (old version).
UPGRADE_APP_VERSION: App version installed during upgrade (new version).
For now, this workflow runs on every pull request.
The open question is:
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile