Open
Conversation
Member
CarlSchwan
commented
Feb 5, 2026
CarlSchwan
commented
- Use getFirstNodeById for performance reason
- Add typing
- Use property contrustor promotion
- Use attributes instead of annotations
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
8 times, most recently
from
d7debe4 to
bd59a97
Compare
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
from
bd59a97 to
bf85e99
Compare
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
4 times, most recently
from
f68516e to
cdcb726
Compare
- Use getFirstNodeById for performance reason - Add typing - Use property contrustor promotion - Use attributes instead of annotations Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
from
cdcb726 to
9d90be4
Compare
susnux
approved these changes
Feb 17, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Nice!
Tests sre related though. Tests need to be adjusted
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
from
9d90be4 to
545df27
Compare
Member
Author
working on it :) |
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
2 times, most recently
from
a998a3d to
af38f3b
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
2 times, most recently
from
b44058e to
d91f5a9
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/modernize-controllers
branch
from
d91f5a9 to
b797112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.