Merged
Conversation
tacruc
force-pushed
the
repectNoMediaAndNoImage
branch
from
e6d8f81 to
6a4384b
Compare
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
=========================================
Coverage ? 58.78%
Complexity ? 1129
=========================================
Files ? 42
Lines ? 3453
Branches ? 0
=========================================
Hits ? 2030
Misses ? 1423
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tacruc
force-pushed
the
repectNoMediaAndNoImage
branch
2 times, most recently
from
3fe68c2 to
749787a
Compare
tacruc
changed the title
tacruc
force-pushed
the
repectNoMediaAndNoImage
branch
2 times, most recently
from
f29d62f to
9bea343
Compare
Signed-off-by: Arne Hamann <git@arne.email>
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
Signed-off-by: Arne Hamann <git@arne.email>
Signed-off-by: Arne Hamann <git@arne.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important commit is 1f0fd5e, the rest is making the tests run.
Based on #725 to have unit tests running.
Kind of fixes #143.
Images are still scanned they are not shown on the map.
To prevent images from being scanned we need #699 to exclude them from the occ:image-scan and something to prevent the scan when the file hooks are triggered.