Skip to content

[stable32] feat(settings): Log AI config changes to audit log #59220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backportbot wants to merge 3 commits into
base: stable32
Choose a base branch
from
+23 −2
Open

[stable32] feat(settings): Log AI config changes to audit log #59220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35f2b7a
feat(settings): Log AI config changes to audit log
marcelklehr Mar 26, 2026
588d060
fix(settings): Throw JSON errors and return 400 status if JSON encode…
marcelklehr Mar 26, 2026
fb8f731
fix(settings): Check all values first, then apply them
marcelklehr Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions apps/settings/lib/Controller/AISettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,28 @@

use OCA\Settings\Settings\Admin\ArtificialIntelligence;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\Attribute\AuthorizedAdminSetting;
use OCP\AppFramework\Http\DataResponse;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\IAppConfig;
use OCP\IRequest;
use OCP\Log\Audit\CriticalActionPerformedEvent;

class AISettingsController extends Controller {

public function __construct(
$appName,
IRequest $request,
private string $userId,
private IAppConfig $appConfig,
private IEventDispatcher $eventDispatcher,
) {
parent::__construct($appName, $request);
}

/**
* Sets the email settings
* Sets the AI settings
*
* @param array $settings
* @return DataResponse
Expand All @@ -38,7 +43,23 @@ public function update($settings) {
if (!isset($settings[$key])) {
continue;
}
$this->appConfig->setValueString('core', $key, json_encode($settings[$key]), lazy: in_array($key, \OC\TaskProcessing\Manager::LAZY_CONFIG_KEYS, true));
try {
$settings[$key] = json_encode($settings[$key], flags: \JSON_THROW_ON_ERROR);
} catch (\JsonException) {
return new DataResponse(['error' => "Setting value for '$key' must be JSON-compatible"], Http::STATUS_BAD_REQUEST);
}
}
foreach ($keys as $key) {
if (!isset($settings[$key])) {
continue;
}
$changed = $this->appConfig->setValueString('core', $key, $settings[$key], lazy: in_array($key, \OC\TaskProcessing\Manager::LAZY_CONFIG_KEYS, true));
if ($changed) {
$this->eventDispatcher->dispatchTyped(new CriticalActionPerformedEvent(
'AI configuration was changed by user %s: %s was set to %s',
[$this->userId, $key, $settings[$key]]
));
}
}

return new DataResponse();
Expand Down
Loading