feat(sharing): allow email-based labels for lookup results

[n-iv]

Summary

Adds an opt-in system config flag shareapi_lookup_label_show_email that, when set to true, makes the LookupPlugin compose suggestion labels with the user's email (from the lookup server response) instead of the federation ID.

Default behavior is strictly preserved when the flag is absent or false.

Motivation

In Global Scale deployments, federation IDs are sharded across nodes (e.g. user@node05.example.org) and do not carry human-readable signal. When the sharing dialog shows two accounts of the same person who happens to be hosted on different nodes, users see:

• Jane Doe (jdoe@node05.example.org)
• Jane Doe (janedoe1@node10.example.org)

The node suffix is implementation detail and does not help the user pick. The email, which the lookup server already exposes in its response, is far more discriminating.

With the flag enabled, the same suggestions become:

• Jane Doe (jane.doe@site-a.example)
• Jane Doe (jane.doe@site-b.example)

Behavior

• Flag absent or false: identical to current master.
• Flag true and email present in lookup response: label uses Name (email) or email if no name.
• Flag true and email missing: graceful fallback to Name (federationId) or federationId.

Tests

• Updated all existing tests in LookupPluginTest to account for the new config read (exactly(3) instead of exactly(2) on getSystemValueBool).
• Added testSearchWithEmailLabel covering the new path with the flag enabled and an email present in the lookup response.

[Copilot]

Pull request overview

This PR adds an opt-in system configuration flag (shareapi_lookup_label_show_email) to change how lookup-server share suggestions are labeled in Global Scale setups: when enabled and the lookup response contains an email, the suggestion label shows Name (email) instead of Name (federationId), while keeping the federation ID as the actual share target.

Changes:

• Read new system config flag shareapi_lookup_label_show_email in LookupPlugin and use lookup-response email for the suggestion label when enabled.
• Update existing LookupPluginTest expectations for the additional config read.
• Add a new unit test covering the “email label” path when the flag is enabled and email is present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
lib/private/Collaboration/Collaborators/LookupPlugin.php	Adds config-driven logic to compose lookup suggestion labels using email when available.
tests/lib/Collaboration/Collaborators/LookupPluginTest.php	Updates mocks for the new config read and adds a new test for the email-label behavior.

Comments suppressed due to low confidence (1)

lib/private/Collaboration/Collaborators/LookupPlugin.php:47

• This config read happens even when Global Scale is disabled (the method returns early right after), so it adds an unnecessary system-config lookup on every non-GS search call. Consider moving the shareapi_lookup_label_show_email read to after the !$isGlobalScaleEnabled early-return to avoid extra work in the common non-GS case.

		$isGlobalScaleEnabled = $this->config->getSystemValueBool('gs.enabled', false);
		$isLookupServerEnabled = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no') === 'yes';
		$hasInternetConnection = $this->config->getSystemValueBool('has_internet_connection', true);
		$showFederatedEmail = $this->config->getSystemValueBool('shareapi_lookup_label_show_email', false);

		// If case of Global Scale we always search the lookup server
		// TODO: Reconsider using the lookup server for non-global scale
		// if (!$isGlobalScaleEnabled && (!$isLookupServerEnabled || !$hasInternetConnection || $disableLookupServer)) {
		if (!$isGlobalScaleEnabled) {
			return false;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.