Skip to content

[stable31] Fix/hide link decoration in read-only mode #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverkszlo merged 1 commit into from
Feb 11, 2026
Merged

[stable31] Fix/hide link decoration in read-only mode #8257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/plugins/previewOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default function previewOptions({ editor }) {
state: {
init(_, { doc }) {
if (!editor.options.editable) {
return { decorations: DecorationSet.create() }
return { linkParagraphs: [], decorations: DecorationSet.empty }
}
const linkParagraphs = extractLinkParagraphs(doc)
return {
Expand All @@ -36,10 +36,11 @@ export default function previewOptions({ editor }) {
}
},
apply(tr, value, _oldState, newState) {
if (!tr.docChanged) {
return value
}
// Always return empty decorations if editor is not editable
if (!editor.options.editable) {
return { linkParagraphs: [], decorations: DecorationSet.empty }
}
if (!tr.docChanged) {
return value
}
const linkParagraphs = extractLinkParagraphs(newState.doc)
Expand Down