Skip to content

Migrate annosine to topic channels#10834

Open
garciafranciscomartn wants to merge 5 commits intomasterfrom
annosine_topics_migration
Open

Migrate annosine to topic channels#10834
garciafranciscomartn wants to merge 5 commits intomasterfrom
annosine_topics_migration

Conversation

@garciafranciscomartn
Copy link
Contributor

Closes #10182

Migrated annosine module from versions.yml to topic channels following the migration guide.

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comment before approving !

tuple val(meta), path("${prefix}.log"), emit: log
tuple val(meta), path("${prefix}.fa") , emit: fa, optional: true
path "versions.yml" , emit: versions
tuple val("${task.process}"), val('annosine'), eval('pip show annosine2 | grep "^Version" | sed "s/Version: //"'), emit: versions_annosine, topic: versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to simplify it by:

Suggested change
tuple val("${task.process}"), val('annosine'), eval('pip show annosine2 | grep "^Version" | sed "s/Version: //"'), emit: versions_annosine, topic: versions
tuple val("${task.process}"), val('annosine'), eval('pip show annosine2 | sed -n "s/Version: //p"'), emit: versions_annosine, topic: versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topic channels: annosine

2 participants