Skip to content

Dragen germline topics migration#10853

Open
DogaTestere wants to merge 3 commits intonf-core:masterfrom
DogaTestere:dragen_germline_topics_migration
Open

Dragen germline topics migration#10853
DogaTestere wants to merge 3 commits intonf-core:masterfrom
DogaTestere:dragen_germline_topics_migration

Conversation

@DogaTestere
Copy link
Contributor

PR checklist

Closes #10773

  • If you've fixed a bug or added code that should be tested, add tests!
  • Broadcast software version numbers to topic: versions - See version_topics
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

[
"DRAGEN",
"dragen",
"bash: line 1: dragen: command not found"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the command capturing the version is not correct. Could you modify it so that it correctly prints the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRAGEN requires specialized hardware to run and the module itself has no docker image to run. I'm not sure if i can make a docker image of a proprietary pipeline.

" // ATTENTION: No conda env or container image as Dragen requires specialized hardware to run" <-- This is what it says on the module file.

path "*_usage.txt" , emit: usage_txt
path "**" , emit: all
path "versions.yml" , emit: versions
tuple val("${task.process}"), val('dragen'), eval("dragen --version 2>&1 | sed 's/^dragen Version //;s/ Hash.*//'"), emit: versions_dragen, topic: versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the command capturing the version is not correct. Could you modify it so that it correctly prints the version?

type: file
description: GFF3 representation of the CNV events
pattern: "*.cnv.gff3"
ontologies: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the ontology for gff

type: file
description: Contains aligned reads
pattern: "*.bam"
ontologies: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing ontologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topics channels: dragen/germline

2 participants