Remove non-standard ext keys and model after quartonotebook#10886
Remove non-standard ext keys and model after quartonotebook#10886mahesh-panchal wants to merge 1 commit intonf-core:masterfrom
Conversation
SPPearce
left a comment
There was a problem hiding this comment.
@mahesh-panchal , I don't really understand what this module is actually doing inside.
Have you checked that the output file is indeed rendered properly?
|
Rendered output: The code is changed so that it's always reading from a params.yml. |
|
There was also an issue where the artifacts directory was mutable but it was hard coded, so there was a decision to make - either make artifacts immutable or mutable, and went with mutable, although the code looks cleaner when it's immutable. |
PR checklist
Part of #8716
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda