Skip to content

Fastavalidator topics migration#10904

Closed
EfraMP wants to merge 0 commit intonf-core:masterfrom
EfraMP:fastavalidator_topics_migration
Closed

Fastavalidator topics migration#10904
EfraMP wants to merge 0 commit intonf-core:masterfrom
EfraMP:fastavalidator_topics_migration

Conversation

@EfraMP
Copy link
Member

@EfraMP EfraMP commented Mar 14, 2026

PR checklist

Partially closes #10832

  • Update topics migration.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@EfraMP EfraMP force-pushed the fastavalidator_topics_migration branch from 1305759 to 273efc4 Compare March 14, 2026 04:17
@EfraMP
Copy link
Member Author

EfraMP commented Mar 14, 2026

The conda failure seems to be pre-existing. The CI runners fail the pkg_resources, but the Docker and Singularity checks pass. What to do??

@EfraMP EfraMP requested review from GallVp and mirpedrol March 14, 2026 04:28
@camlloyd
Copy link
Member

The conda failure seems to be pre-existing. The CI runners fail the pkg_resources, but the Docker and Singularity checks pass. What to do??

Attempt to fix upstream in bioconda/bioconda-recipes#63515

@EfraMP
Copy link
Member Author

EfraMP commented Mar 15, 2026

The conda failure seems to be pre-existing. The CI runners fail the pkg_resources, but the Docker and Singularity checks pass. What to do??

Attempt to fix upstream in bioconda/bioconda-recipes#63515

So then what? I wait for your PR to be merged to Bioconda??

@camlloyd
Copy link
Member

Could you please re-run:

nf-core modules lint fastavalidator --fix
nf-core modules test fastavalidator --update

@EfraMP
Copy link
Member Author

EfraMP commented Mar 15, 2026

Done. The current conda checks continue to fail

task.ext.when == null || task.ext.when

script:
def prefix = task.ext.prefix ?: "${meta.id}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Exit if running this module with -profile conda / -profile mamba
if (workflow.profile.tokenize(',').intersect(['conda', 'mamba']).size() >= 1) {
error "Fastavalidator module does not support Conda. Please use Docker / Singularity instead."
}
def prefix = task.ext.prefix ?: "${meta.id}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, but messed up the branch tracking...

Opened a new PR in #10925

@EfraMP EfraMP force-pushed the fastavalidator_topics_migration branch from 136aca3 to 56e89d0 Compare March 16, 2026 18:48
@EfraMP EfraMP requested review from a team, edmundmiller and maxulysse as code owners March 16, 2026 18:48
@EfraMP EfraMP force-pushed the fastavalidator_topics_migration branch from 56e89d0 to 610cbdd Compare March 16, 2026 18:51
@EfraMP EfraMP closed this Mar 16, 2026
@EfraMP EfraMP force-pushed the fastavalidator_topics_migration branch from 610cbdd to 040e627 Compare March 16, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt topic channels in all nf-core modules [PART 4]

2 participants