Add new component: gridss/preprocess#11988
Open
imsarath wants to merge 3 commits into
Open
Conversation
5e69d6b to
546055c
Compare
beatrizsavinhas
requested changes
Jun 15, 2026
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), | ||
| process.out.findAll { key, val -> key.startsWith("versions") } |
Contributor
There was a problem hiding this comment.
I believe that with nf-test 0.9.5, which the CI for this repo already has, this can be done simply by:
Suggested change
| process.out.findAll { key, val -> key.startsWith("versions") } | |
| topics |
Provided that topics "versions" is added above.
Contributor
There was a problem hiding this comment.
Or even just process.out.versions_gridss? 🤔
Comment on lines
+60
to
+67
| process.out.preprocess_dir.collect { meta, dir -> [meta, file(dir).list().findAll { it.startsWith(prefix) }.sort()] }, | ||
| path("${workdir}/${prefix}.computesamtags.changes.tsv"), | ||
| path("${workdir}/${prefix}.coverage.blacklist.bed"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.cigar_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.idsv_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), |
Contributor
There was a problem hiding this comment.
I think lines 60-67 are actually testing the tool itself, not the module. The behaviour of the tool should be tested in the tool itself. For the nextflow module, I would think checking the process outputs is suficient.
Suggested change
| process.out.preprocess_dir.collect { meta, dir -> [meta, file(dir).list().findAll { it.startsWith(prefix) }.sort()] }, | |
| path("${workdir}/${prefix}.computesamtags.changes.tsv"), | |
| path("${workdir}/${prefix}.coverage.blacklist.bed"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.cigar_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.idsv_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), | |
| process.out |
Looking at the tests for cadd for example, that seems to be the case. 🤔
| versions: | ||
| - - ${task.process}: | ||
| type: string | ||
| description: The process |
Contributor
There was a problem hiding this comment.
Suggested change
| description: The process | |
| description: The name of the process |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of the distributed computing GRIDSS subworkflow #4498 , I added this gridss/preprocess module. This pre-processing step in GRIDSS extracts multiple Picard metrics (insert size, MAPQ, CIGAR, IDSV, tag, and coverage) from an input BAM file prior to assembly and variant calling.
PR checklist
Closes #4499
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda