migrate leviosam2/lift module to topic channels#12000
Open
Anifowak wants to merge 1 commit into
Open
Conversation
dff7ba2 to
c8bd796
Compare
c8bd796 to
6f6fced
Compare
6f6fced to
7385428
Compare
7385428 to
046dc20
Compare
SPPearce
reviewed
Jun 13, 2026
SPPearce
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution.
A few suggestions to get this to pass. You'll need to regenerate the snapshots too.
Comment on lines
+146
to
+149
| { assert snapshot( | ||
| process.out.bam, | ||
| process.out.versions_leviosam2 | ||
| ).match() |
Contributor
There was a problem hiding this comment.
The stub test can always be this:
Suggested change
| { assert snapshot( | |
| process.out.bam, | |
| process.out.versions_leviosam2 | |
| ).match() | |
| { assert snapshot(sanitizeOutput(process.out)).match() |
| assert snapshot( | ||
| process.out.bam.collect { file(it[1]).getName() }, | ||
| process.out.versions | ||
| process.out.versions_leviosam2 |
Contributor
There was a problem hiding this comment.
This passes the linting:
Suggested change
| process.out.versions_leviosam2 | |
| process.out.findAll { key, val -> key.startsWith('versions') }, |
Alternatively, the whole snapshot could be `snapshot(sanitizeOutput(process.out, unstableKeys: ["bam"])).match()
Contributor
Author
|
Alright. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #11907
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda