Update waveform conversion code to account for new timing fields#333
Merged
Conversation
… fix existing tests. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
Test Results 120 files ± 0 120 suites ±0 3m 18s ⏱️ -4s Results for commit da641d0. ± Comparison against base commit 0b84363. This pull request removes 71 and adds 186 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…al mode. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
mjohanse-emr
commented
May 20, 2026
…ed to time_offset. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…s point, it's super annoying. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
bkeryan
requested changes
May 21, 2026
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
bkeryan
reviewed
May 21, 2026
…sing. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…o verify normalization. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
… for easier maintainability where it makes sense. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…ssible. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
jasonmreding
approved these changes
May 26, 2026
jasonmreding
left a comment
There was a problem hiding this comment.
I only did a cursory review of the test changes as I assume it was mostly refactoring. If you want a more thorough review of anything in particular, let me know.
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
bkeryan
requested changes
Jun 2, 2026
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…class. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
bkeryan
reviewed
Jun 3, 2026
bkeryan
reviewed
Jun 3, 2026
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
bkeryan
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
AB#3877566
Updates the waveform conversion functions to handle the following new timing fields:
timestamptime_offsettimestampsNI-APIs change to add the new fields
Unit tests have been added to test conversion cases specific to these parameters.
Existing unit tests have been updated where necessary (example, don't expect and exception for irregular timing anymore). Unit test updates include
Similar change in the C# API
Why should this Pull Request be merged?
To establish parity between our python API and our C# API.
To allow Python users to publish Irregular Timing waveforms and "Relative Timing" waveforms.
What testing has been done?
Many new tests have been added that were inspired by the C# auto tests.
Existing waveform conversion tests are passing.