Add explicit service package exports#213
Draft
fredvisser wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes each nisystemlink.clients.<service> package’s public surface explicit by adding a short “Start here…” package docstring and replacing blanket # flake8: noqa exports with explicit __all__ declarations, plus a regression test to enforce that contract.
Changes:
- Added “Start here…” package docstrings pointing to the primary client/entry point per service package.
- Replaced blanket
# flake8: noqaexports with explicit__all__lists across service packages (with narrow# noqa: I100import-order suppressions intag). - Added a test that validates each service package has the docstring and explicit exports.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_service_package_exports.py | Adds regression test enforcing docstring + explicit __all__/import surface per service package. |
| nisystemlink/clients/alarm/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/artifact/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/assetmanagement/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/dataframe/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/feeds/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/file/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/notebook/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/notification/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/product/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/spec/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/systems/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/tag/init.py | Adds “Start here…” docstring, explicit __all__, and scoped import-order suppressions. |
| nisystemlink/clients/test_plan/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/testmonitor/init.py | Adds “Start here…” docstring and explicit __all__. |
| nisystemlink/clients/work_item/init.py | Adds “Start here…” docstring and explicit __all__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+61
| self.assertIsNotNone(module_docstring) | ||
| assert module_docstring is not None | ||
| self.assertTrue(module_docstring.startswith("Start here with ")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# flake8: noqapackage exports with explicit__all__declarations across service packagesWhy This Helps
Validation
poetry run poe checkpoetry run poe lintpoetry run poe typespoetry run poe testNotes
nisystemlink.clients.tagkeeps a few narrow# noqa: I100import-order suppressions because its runtime-safe import order is intentionally different from alphabetical order; the touched tag import path is covered by tests