Skip to content

Nick/lesson2#162

Open
Camarill wants to merge 4 commits intonickovchinnikov:masterfrom
Camarill:nick/lesson2
Open

Nick/lesson2#162
Camarill wants to merge 4 commits intonickovchinnikov:masterfrom
Camarill:nick/lesson2

Conversation

@Camarill
Copy link

No description provided.

"**": sqr,
};

export const mathOperators: { [key: string]: MathOperationType } = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string можно заменить на enum


export const sqr: UnionOperationType = (first: number): number => pow(first, 2);

export const unionOperators: { [key: string]: MathOperationType } = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string можно заменить на enum


export const parseBrackets = (line: string): string => {

var k = 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val? очень плохой синтаксис

var k = 1;

do {
var openBracket = line.lastIndexOf("(");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо причесать этот кусок кода, который явно скопирован откуда-то

import { mathOperators } from "./mathOperators";
import { isNumber, isOperator, isUnionOperator } from "./helpers";
import { mathOperators,
unionOperators } from "./mathOperators";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишний перенос на новую строку

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments