Open
Conversation
- handling user-defined reduction functions - error-trapping non-user defined invalid reduction functions - setting default init values - fixing up handling of inf and negative init values - allowing a user to specify the reduction fun as char or actual function.
…ts are contained in private, and packaged names can be managed (#125) * initial redesign of nClass to hold a private Cpublic_obj and use it by active bindings * Add basic nClass_uncompiled tests * major work towards redesigning nClass generation and hierarchy * fix C++ handling (Exporter and generic interface set) of new nClass structure * close to finished with updated class naming issues within packages * updated tests after new packingNames and nCompile naming schemes * update predefineds. fix nimbleModels. fix package class generation with R fields. * fix StridedTensorMap operator() for single index * fix cpp_tests crash * test trials * give each case in test-argumentPassing unique package naming * Fix test-tensorCreation for old style
Also handle missing shareVars or copyVars args.
Also handle use of external object in parallel_for.
parallel_loop_body cases a unique ID. This addresses problems with different parfors in different methods of a class.
- allow multiple parallel_reduce operations - handle local method as the reduction operator.
- use without assignment or in return() - use in return() - multiple calls to parallel_reduce at same level of AST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses various aspects of
parallel_reduce, with a fair amount of testing. I generally tried to work within the system, but there may be cases where @perrydv may think we should do it differently or at a different stage.reduction = <some_init>. The existence of this is used for error trappling for valid reduction operators (perhaps this is trying to be too concise by combining the idea of a valid operator with the default init).reduction_op(x,y)to determine type, but it seemed most natural to me to use the type of the vector.joinfor various situations.The following are still issues:
pair{min,max}as these are the actual relevant binary operators. We should discuss if we want to automatically convert {min,max} to these for the user.parallelReducefor consistency with other user-facing naming?