Conversation
|
Oops I guess I should have branched from devel instead of |
|
rhub checking suggests the changes are good. R_MissingArg is the only thing being flagged in terms of non-API calls. The rchk getSEXPdims(SEXPREC*) error is gone, though the other weird rchk issues remain as we expected. |
|
All non-Windows tests passed. We think there is an issue with our Windows CI setup, so I am running some tests on Windows locally. So far they are passing. I will report when they are completed. @paciorek tried checks on r-hub and reports the confusingly phrased |
|
Following up: I was able to run all of the tests normally run on Windows successfully with one exception that does involve the PR: In
I also ran So I consider this PR to be passing tests. |
|
I'll plan to merge this. Ok @perrydv ? I'll rerun R CMD check, send to win-builder and run the key r-hub checks, and then resubmit. |
|
Yes that sounds good to me. |
do not merge.
This branch extends
fix-findVar-API-callwith further changes. See #1615 .This branch removes use of
R_UnboundValue, changesGET_SLOTtoR_do_slot, removes use ofR_BracketSymbol, and add aPROTECTaround anRf_getAttribresult passed intogetSEXPdims(the newPROTECTreally looks unnecessary asgetSEXPdimsdoes call any R function, but it is being newly flagged byrchkas far as we can tell).The change to
R_do_slotwas also done with superficial changes that reduced the number ofPROTECTcalls and matchingUNPROTECTcounts.A difficulty in deciding what to do is that CRAN's demands for making API usages stricter are not completely clearly listed and documented.