Add ApplicationDataValueWrite::SignedInt and UnsignedInt variants.#9
Conversation
545f377 to
253b784
Compare
253b784 to
bc4846f
Compare
46c6978 to
9b4418c
Compare
bae1f20 to
4733806
Compare
|
Hey, thanks for your contribution. I really appreciate it. Can you please just write a short description of what you have added so that I don't have to read the code to figure it out. Just a bit more detail than you put in. This will help me answer two questions. Is this change here to get some proprietary device to work that won't benefit anyone else? Is the code written by an human? (it changes the way I review it). No offense intended btw, just the nature of things these days. :) |
|
No offense taken. It's all written by me personally. No AI. The changes:
This is not for any specific quirk in a proprietary device, but to extend support for standard integer properties: reading signed values, writing signed and unsigned values, and decoding more valid integer encodings. |
ninjasource
left a comment
There was a problem hiding this comment.
Thanks for your contribution, looks good! I really appreciate it.
|
Thanks for the quick review! |
This PR adds a
SignedIntandUnsignedIntvariants forApplicationDataValueWriteto support writing integer values.