Fixed some gcc compiler warnings when using stricter options#26
Open
jniemann66 wants to merge 2 commits intonitroshare:masterfrom
Open
Fixed some gcc compiler warnings when using stricter options#26jniemann66 wants to merge 2 commits intonitroshare:masterfrom
jniemann66 wants to merge 2 commits intonitroshare:masterfrom
Conversation
|
Same issue here. For me, qhttpengine works phantastically well, but the compiler warnings are a nuisance. I would much appreciate if this was fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a project that mandated the use of -Wall -Wextra -Werror
This resulted in a few build errors, such as incorrect member initializer order, unused parameter, missing default in switch statement.
So, I cleaned those up, and thought this might be of use.
Note There is still a '/* within comment' issue with line 184 of range.h - not sure what the best approach to fixing that is.
Anyway - QHttpEngine works a treat - much appreciated ! If there is anything I can help with, then let me know.
Cheers,
Judd