[doc] Add default and optional values for arguments in documentation#267
Merged
Conversation
…date documentation
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (67.3%)
Reported by octocov |
Schiano-NOAA
requested changes
May 21, 2026
Collaborator
There was a problem hiding this comment.
Thanks for doing this! It generally looks good. Only change that needs to be made is that scale_amount for I believe all functions is a numeric value and the default should be 1 not "1"
Also in regards to your comment in #264, instead of rebasing that branch to this one, I think we should just mege this one when it's finished then I can rebase to main on the other branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default and optional values for arguments in documentation as per #256