Skip to content

docs: add #nodejs-distributions Slack link to CONTRIBUTING#2419

Open
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399:add-slack-links
Open

docs: add #nodejs-distributions Slack link to CONTRIBUTING#2419
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399:add-slack-links

Conversation

@MikeMcC399
Copy link
Contributor

Description

Add the OpenJS Foundation Slack and the new #nodejs-distributions channel links to the CONTRIBUTING document.

Include also a link to the related #nodejs-release Slack channel.

Motivation and Context

The #nodejs-distributions Slack channel was created on March 11, 2026. Linking the channel into the CONTRIBUTING document allows it to be more easily discovered and used.

Slack extends the ability to conduct discussions that don't directly fit into GitHub Issues / Pull Request spaces.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 12, 2026 08:02
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in two minds about whether it's worth referencing the snap repo explicitly (mostly because a list of potential other repositories need to be updated) but I'm also ok if you want to leave it in.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Mar 12, 2026

I'm in two minds about whether it's worth referencing the snap repo explicitly (mostly because a list of potential other repositories need to be updated) but I'm also ok if you want to leave it in.

Thanks for the feedback! I've removed the reference to snap.

I also squashed the change, because this repo seems to merge PRs as-is rather than squash commits.

@MikeMcC399
Copy link
Contributor Author

@sxa
Copy link
Member

sxa commented Mar 12, 2026

I also squashed the change, because this repo seems to merge PRs as-is rather than squash commits.

Hmmm yes I don't get an option to "squash and merge" automatically in this repo so that's appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants