v10.15.0 proposal by MylesBorins · Pull Request #25176 · nodejs/node

MylesBorins · 2018-12-21T23:46:07Z

2018-12-26, Version 10.15.0 'Dubnium' (LTS), @MylesBorins

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.

Notable Changes

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

Commits

[9b2ffc81c0] - (SEMVER-MINOR) cli: add --max-http-header-size flag (cjihrig) #24811
[6183c7107d] - (SEMVER-MINOR) deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811
[e669733595] - doc: describe current HTTP header size limit (Sam Roberts) #24700
[b6d3afb257] - (SEMVER-MINOR) http: add maxHeaderSize property (cjihrig) #24860
[1aea1e3634] - http: fix regression of binary upgrade response body (Matteo Collina) #25039
[a57aed144a] - (SEMVER-MINOR) src: add kUInteger parsing (Matteo Collina) #24811
[527407c49f] - src: cache the result of GetOptions() in JS land (Joyee Cheung) #24091
[728bc631e5] - test: fix expectation in test-bootstrap-modules (Ali Ijaz Sheikh) #25112
[3e14212f0e] - test: remove magic numbers in test-gc-http-client-onerror (Rich Trott) #24943

nodejs-github-bot · 2018-12-21T23:46:09Z

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2035/pipeline

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25176

MylesBorins · 2018-12-21T23:56:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19732/

doc/changelogs/CHANGELOG_V10.md

MylesBorins · 2018-12-22T05:00:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19745/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1700/
rc.1: https://nodejs.org/download/rc/v10.15.0-rc.1/

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25176

mcollina

lgtm

Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Instead of calling into C++ each time we need to check the value of a command line option, cache the option map in a new `internal/options` module for faster access to the values in JS land. PR-URL: #24091 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

PR-URL: #25039 Fixes: #24958 Reviewed-By: Myles Borins <myles.borins@gmail.com>

This commit adds http_parser_set_max_header_size() to the http-parser for overriding the compile time maximum HTTP header size. Backport-PR-URL: #25168 PR-URL: #24811 Fixes: #24692 Refs: nodejs/http-parser#453 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This commit adds support for uint64_t option parsing. Backport-PR-URL: #25168 PR-URL: #24811 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Allow the maximum size of HTTP headers to be overridden from the command line. Backport-PR-URL: #25168 co-authored-by: Matteo Collina <hello@matteocollina.com> PR-URL: #24811 Fixes: #24692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25176

MylesBorins · 2018-12-25T07:19:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/

Added fix to flaky test. CITGM looks good

Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

This commit exposes the value of --max-http-header-size as a property of the http module. PR-URL: #24860 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25176

MylesBorins · 2018-12-25T16:26:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19806/ ✅ (only failure is known flake on AIX, retrying)
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1703/ ✅ (manually tested failures and updated skip / flaky references in citgm lookup)
rc.2: https://nodejs.org/download/rc/v10.15.0-rc.2/

PR-URL: #25176

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25176

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) nodejs#24811 * http: - add maxHeaderSize property (cjihrig) nodejs#24860 PR-URL: nodejs#25176

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Dec 21, 2018

MylesBorins force-pushed the v10.15.0-proposal branch from 51c36d7 to 34a76c1 Compare December 21, 2018 23:46

MylesBorins force-pushed the v10.15.0-proposal branch from 34a76c1 to a5e2e86 Compare December 21, 2018 23:50

MylesBorins mentioned this pull request Dec 21, 2018

special release for all release lines to fix regressions from last security release nodejs/Release#401

Closed

richardlau reviewed Dec 22, 2018

View reviewed changes

doc/changelogs/CHANGELOG_V10.md Outdated Show resolved Hide resolved

MylesBorins force-pushed the v10.15.0-proposal branch from a5e2e86 to daa54f3 Compare December 22, 2018 04:41

MylesBorins force-pushed the v10.15.0-proposal branch from daa54f3 to fce1b91 Compare December 22, 2018 04:42

This comment has been minimized.

Sign in to view

MylesBorins force-pushed the v10.15.0-proposal branch from fce1b91 to 4e393f9 Compare December 22, 2018 05:30

MylesBorins force-pushed the v10.15.0-proposal branch from 4e393f9 to b4496e0 Compare December 22, 2018 06:48

mcollina approved these changes Dec 22, 2018

View reviewed changes

cjihrig approved these changes Dec 22, 2018

View reviewed changes

Trott and others added 7 commits December 25, 2018 02:17

test: fix expectation in test-bootstrap-modules

728bc63

PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

http: fix regression of binary upgrade response body

1aea1e3

PR-URL: #25039 Fixes: #24958 Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins force-pushed the v10.15.0-proposal branch from b4496e0 to cb51fc4 Compare December 25, 2018 07:18

sam-github and others added 2 commits December 25, 2018 09:48

doc: describe current HTTP header size limit

e669733

Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins force-pushed the v10.15.0-proposal branch from cb51fc4 to b2d339c Compare December 25, 2018 14:50

MylesBorins force-pushed the v10.15.0-proposal branch from b2d339c to 1ae0511 Compare December 25, 2018 15:09

MylesBorins merged commit 1ae0511 into v10.x Dec 26, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

Working on v10.15.1

b3e1205

PR-URL: #25176

MylesBorins mentioned this pull request Dec 26, 2018

blog: release posts for dec 26th releases nodejs/nodejs.org#1961

Merged

codebytere mentioned this pull request Jan 15, 2019

v10.15.1 proposal #25346

Merged

targos deleted the v10.15.0-proposal branch June 4, 2019 14:20

bnoordhuis mentioned this pull request Jul 3, 2019

Node 10.8.0 does not support lookup on Agent #27695

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

v10.15.0 proposal#25176

v10.15.0 proposal#25176
MylesBorins merged 10 commits intov10.xfrom
v10.15.0-proposal

MylesBorins commented Dec 21, 2018 •

edited

Loading

Uh oh!

nodejs-github-bot commented Dec 21, 2018

Uh oh!

MylesBorins commented Dec 21, 2018

Uh oh!

Uh oh!

MylesBorins commented Dec 22, 2018 •

edited

Loading

Uh oh!

This comment has been minimized.

mcollina left a comment

Uh oh!

MylesBorins commented Dec 25, 2018

Uh oh!

MylesBorins commented Dec 25, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

MylesBorins commented Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2018-12-26, Version 10.15.0 'Dubnium' (LTS), @MylesBorins

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Dec 21, 2018

Uh oh!

MylesBorins commented Dec 21, 2018

Uh oh!

Uh oh!

MylesBorins commented Dec 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Dec 25, 2018

Uh oh!

MylesBorins commented Dec 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

MylesBorins commented Dec 21, 2018 •

edited

Loading

MylesBorins commented Dec 22, 2018 •

edited

Loading

MylesBorins commented Dec 25, 2018 •

edited

Loading