[v12.x] http: add maxTotalSockets to agent class#35396
Closed
rickyes wants to merge 2 commits intonodejs:v12.x-stagingfrom
Closed
[v12.x] http: add maxTotalSockets to agent class#35396rickyes wants to merge 2 commits intonodejs:v12.x-stagingfrom
rickyes wants to merge 2 commits intonodejs:v12.x-stagingfrom
Conversation
Add maxTotalSockets to determine how many sockets an agent can open. Unlike maxSockets, The maxTotalSockets does not count by per origin. PR-URL: nodejs#33617 Fixes: nodejs#31942 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#34013 Refs: nodejs#33617 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
4 tasks
2 tasks
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
Landed in b9d0f73...1a8669d |
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2020
Add maxTotalSockets to determine how many sockets an agent can open. Unlike maxSockets, The maxTotalSockets does not count by per origin. PR-URL: #33617 Backport-PR-URL: #35396 Fixes: #31942 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.
PR-URL: #33617
PR-URL: #34013
Fixes: #31942
Reviewed-By: @ronag
Reviewed-By: @mcollina
Reviewed-By: @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes