Skip to content

zlib: validate write_result array length #61342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
islandryu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zlib: validate write_result array length #61342

islandryu wants to merge 1 commit into from
+96 −0

Conversation

@islandryu
Copy link
Member

@islandryu islandryu commented Jan 11, 2026

Fixes: #61286

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Jan 11, 2026
@codecov
Copy link

codecov bot commented Jan 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (5d9855b) to head (07320af).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_zlib.cc 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61342      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.02%     
==========================================
  Files         704      704              
  Lines      208739   208742       +3     
  Branches    40280    40276       -4     
==========================================
- Hits       184787   184763      -24     
- Misses      15969    15982      +13     
- Partials     7983     7997      +14
Files with missing lines Coverage Δ
src/node_zlib.cc 77.57% <0.00%> (-0.61%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334
Renegade334 approved these changes Jan 11, 2026
View reviewed changes
test/parallel/test-zlib-init-assert.js
@@ -0,0 +1,93 @@
'use strict';
Copy link
Member

@Renegade334 Renegade334 Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others may have differing opinions, but I'm not sure we need regression tests for deliberately illegal use of undocumented internals?

Copy link
Member

@anonrig anonrig Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 11, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 11, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70772/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments

@Renegade334 Renegade334 Renegade334 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Out-of-bounds write in Node.js zlib private api

5 participants

@islandryu @nodejs-github-bot @anonrig @Renegade334 @avivkeller