-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
deps: rewrite HexEncode impl #61609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ChALkeR
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
ChALkeR:chalker/tohex/0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
deps: rewrite HexEncode impl #61609
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
1599c68 to
fe74ddb
Compare
Member
Author
|
nbytes PR: nodejs/nbytes#12 |
Member
Author
|
Second Benchmark CI run, with Huh, this seems worse than the original no-if impl: |
Member
Author
|
Third Benchmark CI run, ternary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
performance
Issues and PRs related to the performance of Node.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this for the hex part of #60249
This PR exists mainly to run benchmarks for now
This improves
Buffer#toString('hex')2-4xIn local tests on a MacBook, this improves
.toString('hex')throughput from ~2.24 GiB/sto ~9.53 GiB/son ~80 KiB chunksFor comparison,
Uint8Array#toHex()shows3.28 GiB/s.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1790/console