-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
test: update FileAPI tests from WPT #61750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
|
I noticed another bug in the implementation while looking at the remaining failures here, for which I submitted tests upstream. I've added those to this PR as well. The CI failures seem to be caused by the github outage yesterday. |
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - test: update FileAPI tests from WPT ⚠ - fixup! test: update FileAPI tests from WPT ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/21860435679 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61750 +/- ##
==========================================
- Coverage 89.75% 89.74% -0.01%
==========================================
Files 674 675 +1
Lines 204416 204642 +226
Branches 39285 39322 +37
==========================================
+ Hits 183472 183666 +194
- Misses 13227 13262 +35
+ Partials 7717 7714 -3 🚀 New features to boost your workflow:
|
joyeecheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
|
It seems (thanks to Milad for pointing out #55194) that the tests involving typed arrays don't work on the big endian build bots - I hope marking them as flaky will allow the CI to pass. This seems like a better outcome than keeping the outdated tests indefinitely. |
Notably, the
test_blob()helper functions no longer usesFileReader, so tests using them can now run successfully in node.