-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
stream: add fast paths for webstreams read and pipeTo #61807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+132
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| 'use strict'; | ||
| const common = require('../common.js'); | ||
| const { ReadableStream } = require('node:stream/web'); | ||
|
|
||
| // Benchmark for reading from a pre-buffered ReadableStream. | ||
| // This measures the fast path optimization where data is already | ||
| // queued in the controller, avoiding DefaultReadRequest allocation. | ||
|
|
||
| const bench = common.createBenchmark(main, { | ||
| n: [1e5], | ||
| bufferSize: [1, 10, 100, 1000], | ||
| }); | ||
|
|
||
| async function main({ n, bufferSize }) { | ||
| let enqueued = 0; | ||
|
|
||
| const rs = new ReadableStream({ | ||
| start(controller) { | ||
| // Pre-fill the buffer | ||
| for (let i = 0; i < bufferSize; i++) { | ||
| controller.enqueue('a'); | ||
| enqueued++; | ||
| } | ||
| }, | ||
| pull(controller) { | ||
| // Refill buffer when pulled | ||
| const toEnqueue = Math.min(bufferSize, n - enqueued); | ||
| for (let i = 0; i < toEnqueue; i++) { | ||
| controller.enqueue('a'); | ||
| enqueued++; | ||
| } | ||
| if (enqueued >= n) { | ||
| controller.close(); | ||
| } | ||
| }, | ||
| }, { | ||
| // Use buffer size as high water mark to allow pre-buffering | ||
| highWaterMark: bufferSize, | ||
| }); | ||
|
|
||
| const reader = rs.getReader(); | ||
| let x = null; | ||
| let reads = 0; | ||
|
|
||
| bench.start(); | ||
| while (reads < n) { | ||
| const { value, done } = await reader.read(); | ||
| if (done) break; | ||
| x = value; | ||
| reads++; | ||
| } | ||
| bench.end(reads); | ||
| console.assert(x); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the only difference between the fast and slow paths is that the fast path calls
PromiseResolve()while the slow path calls[kChunk]which callsPromiseWithResolvers().resolve(). The rest of the code is just a copy-paste ofreadableStreamDefaultControllerPullSteps.Comparing the specification for PromiseResolve and Promise.withResolvers, they seem identical? The first calls
promiseCapability.[[Resolve]]immediately, while the second exposes that samepromiseCapability.[[Resolve]]as a function on the resultingobj. So there shouldn't be a difference in the number of microtasks: both resolve the promise immediately.So where is the speed up coming from?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so
Promise.withResolversis really just slower... Huh. 🤔Results: