tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket#62004
Open
tadjik1 wants to merge 1 commit intonodejs:mainfrom
Open
tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket#62004tadjik1 wants to merge 1 commit intonodejs:mainfrom
tadjik1 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Renegade334
reviewed
Feb 26, 2026
Comment on lines
19
to
25
| // Retrieve internal symbols used by net.Socket to store socket options. | ||
| const symbols = Object.getOwnPropertySymbols(new net.Socket()); | ||
| const kSetNoDelay = symbols.find((s) => s.toString() === 'Symbol(kSetNoDelay)'); | ||
| const kSetKeepAlive = | ||
| symbols.find((s) => s.toString() === 'Symbol(kSetKeepAlive)'); | ||
| const kSetKeepAliveInitialDelay = | ||
| symbols.find((s) => s.toString() === 'Symbol(kSetKeepAliveInitialDelay)'); |
Member
There was a problem hiding this comment.
Is it worth just moving the symbols to internal/net so that we can access them for testing?
Contributor
Author
There was a problem hiding this comment.
Thanks @Renegade334, good idea. Moved those 3 Symbols to internal/net and replaced this part of the test with simple import.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62004 +/- ##
=======================================
Coverage 89.72% 89.73%
=======================================
Files 676 676
Lines 205988 205997 +9
Branches 39490 39487 -3
=======================================
+ Hits 184830 184846 +16
- Misses 13295 13298 +3
+ Partials 7863 7853 -10
🚀 New features to boost your workflow:
|
5 tasks
Member
Contributor
Author
|
It seems like pre-existing flake, I see this test ( 10ms for the timeout is probably too sensitive to CI network. |
addaleax
approved these changes
Feb 26, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM
Can the commit message be updated with the context from the PR description? Rebasing/amending commits is fine 🙂
`tls.connect()` silently ignores `keepAlive`, `keepAliveInitialDelay`, and `noDelay` options. The documentation states it accepts any `socket.connect()` option, and `net.createConnection()` with the same options works correctly. Forward the options through both code paths so `net.Socket`'s constructor stores them on the internal symbols (`kSetNoDelay`, `kSetKeepAlive`, `kSetKeepAliveInitialDelay`), which `afterConnect()` then applies to the handle. Fixes: nodejs#62003
tadjik1
force-pushed
the
fix/tls-connect-keepalive-nodelay
branch
from
e4c82ea to
a373f56
Compare
addaleax
added
author ready
Renegade334
approved these changes
Feb 26, 2026
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tls.connect()silently ignoreskeepAlive,keepAliveInitialDelay, andnoDelayoptions. The documentation states it accepts anysocket.connect()option, andnet.createConnection()with the same options works correctly.This forwards the options through both points so
net.Socket's constructor stores them on the internal symbols (kSetNoDelay,kSetKeepAlive,kSetKeepAliveInitialDelay), whichafterConnect()then applies to the handle.Fixes: #62003
I believe this is a good candidate for backport, as it fixes a silent options-dropping bug in
tls.connect()that affectskeepAlive/noDelaybehavior (in particular with AWS Lambda on 20.x runtime).