Skip to content

test: avoid initial-break wait in restart-message#62060

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-debugger-restart
Open

test: avoid initial-break wait in restart-message#62060
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-debugger-restart

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Mar 1, 2026

Summary

Follow-up to #61773

test/parallel/test-debugger-restart-message.js can still flake on macOS unusual-path runs at the initial waitForInitialBreak(). This change syncs startup on Debugger attached. plus prompt.

failed CI log (main branch): https://github.com/nodejs/node/actions/runs/22545396955

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions parallel/test-debugger-restart-message
  • ./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-restart-message
  • CI passes on macOS

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (4d0cb65) to head (3aa0054).
⚠️ Report is 213 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62060      +/-   ##
==========================================
- Coverage   91.63%   89.65%   -1.98%     
==========================================
  Files         337      676     +339     
  Lines      140376   206240   +65864     
  Branches    21768    39505   +17737     
==========================================
+ Hits       128627   184897   +56270     
- Misses      11527    13473    +1946     
- Partials      222     7870    +7648     

see 460 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 25, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62060
✔  Done loading data for nodejs/node/pull/62060
----------------------------------- PR info ------------------------------------
Title      test: avoid initial-break wait in restart-message (#62060)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     inoway46:fix-flaky-debugger-restart -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: avoid initial-break wait in restart-message
Committers 1
 - inoway46 <inoueyuya416@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62060
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62060
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 01 Mar 2026 15:42:47 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62060#pullrequestreview-3884836184
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/23564673240

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 1, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants