Open
Conversation
44720ea to
0221ebd
Compare
0221ebd to
5861bc1
Compare
Member
|
cc @nodejs/diagnostics |
addaleax
reviewed
Mar 16, 2026
Qard
reviewed
Mar 16, 2026
Member
Qard
left a comment
There was a problem hiding this comment.
Some DX and future-looking recommendations, but otherwise LGTM.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62273 +/- ##
==========================================
- Coverage 91.54% 89.72% -1.83%
==========================================
Files 351 693 +342
Lines 147704 214205 +66501
Branches 23216 41079 +17863
==========================================
+ Hits 135223 192193 +56970
- Misses 12228 14086 +1858
- Partials 253 7926 +7673
🚀 New features to boost your workflow:
|
Qard
approved these changes
Mar 17, 2026
Collaborator
gurgunday
approved these changes
Mar 17, 2026
Qard
approved these changes
Mar 26, 2026
Collaborator
Collaborator
Collaborator
jasnell
reviewed
Mar 27, 2026
4cc95a5 to
76d5907
Compare
Qard
approved these changes
Mar 30, 2026
jasnell
approved these changes
Mar 30, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR succeeds #60231 by @theanarkh and adds parameter support for heap sampling on both the main thread and workers.