Skip to content

test: disable flaky WPT Blob test on AIX#62470

Open
jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell:jasnell/disable-wpt-blob-test-on-aix
Open

test: disable flaky WPT Blob test on AIX#62470
jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell:jasnell/disable-wpt-blob-test-on-aix

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Mar 28, 2026

The test Blob-array-buffer.any.js can be flaky on AIX due to a recognized race condition in v8.

The failed assert is in deps/v8/src/base/platform/platform-aix.cc on line 199, preceeded by the comment:

// If this check fails it's most likely due to a racing condition where
// another thread has mapped the same address right before we do.
// Since this could cause hard-to-debug issues, potentially with security
// impact, and we can't recover from this, the best we can do is abort the
// process.

Disabling the test on AIX until the underlying issue can be resolved (if it can be resolved at all) is really the only option currently.

Reliability Report: https://github.com/nodejs/reliability/blob/main/reports/2026-03-28.md
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus 4.6

@jasnell jasnell added test Issues and PRs related to the tests. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 28, 2026
@jasnell jasnell force-pushed the jasnell/disable-wpt-blob-test-on-aix branch from 083ceae to d1180e7 Compare March 28, 2026 05:11
The test Blob-array-buffer.any.js can be flaky on
AIX due to a recognized race condition in v8.

The failed assert is in deps/v8/src/base/platform/platform-aix.cc
on line 199, preceeded by the comment:

> If this check fails it's most likely due to a racing condition
> where another thread has mapped the same address right before we
> do. Since this could cause hard-to-debug issues, potentially with
> security impact, and we can't recover from this, the best we can do
> is abort the process.

Disabling the test on AIX until the underlying issue can
be resolved (if it can be resolved at all) is really the
only option currently.

Reliability Report: https://github.com/nodejs/reliability/blob/main/reports/2026-03-28.md
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus 4.6
@jasnell jasnell force-pushed the jasnell/disable-wpt-blob-test-on-aix branch from d1180e7 to 9b8afaa Compare March 28, 2026 05:29
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e78ccd8) to head (9b8afaa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62470   +/-   ##
=======================================
  Coverage   89.70%   89.71%           
=======================================
  Files         691      691           
  Lines      213935   213953   +18     
  Branches    41050    41050           
=======================================
+ Hits       191907   191944   +37     
+ Misses      14095    14085   -10     
+ Partials     7933     7924    -9     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2026
Copy link
Copy Markdown
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at that, cjs status files being useful for someone else than me :D

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants