Skip to content

crypto: recognize raw formats in keygen#62480

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:raw-keygen
Open

crypto: recognize raw formats in keygen#62480
panva wants to merge 1 commit intonodejs:mainfrom
panva:raw-keygen

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Mar 28, 2026

Follow up to #62240, this needs no doc changes since

If a publicKeyEncoding or privateKeyEncoding was specified, this function behaves as if keyObject.export() had been called on its result.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva requested a review from jasnell March 28, 2026 20:20
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 28, 2026
@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 77.95276% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.70%. Comparing base (8ea96e6) to head (69ae6f4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 73.49% 9 Missing and 13 partials ⚠️
lib/internal/crypto/keys.js 86.36% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62480      +/-   ##
==========================================
- Coverage   91.55%   89.70%   -1.85%     
==========================================
  Files         350      691     +341     
  Lines      147610   214071   +66461     
  Branches    23212    41089   +17877     
==========================================
+ Hits       135139   192025   +56886     
- Misses      12217    14098    +1881     
- Partials      254     7948    +7694     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.46% <86.36%> (-0.35%) ⬇️
src/crypto/crypto_keys.cc 72.02% <73.49%> (ø)

... and 461 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants