Skip to content

deps: libuv: revert 3a9a6e3e6b#62511

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:revert-libuv-commit
Mar 30, 2026
Merged

deps: libuv: revert 3a9a6e3e6b#62511
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:revert-libuv-commit

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Mar 30, 2026

This commit reverts "tcp: support customizing TCP_KEEPINTVL and TCP_KEEPCNT".
Without this revert, we see a lot of flakyness on Windows CI.

Refs: #62497 (comment)
Refs: libuv/libuv@3a9a6e3

This commit reverts "tcp: support customizing TCP_KEEPINTVL
and TCP_KEEPCNT".
Without this revert, we see a lot of flakyness on Windows CI.
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Mar 30, 2026
@aduh95 aduh95 requested review from jasnell and lpinca March 30, 2026 18:04
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Mar 30, 2026
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Mar 30, 2026

Adding dont-land labels for now, release lines are probably better off waiting for a new upstream release with either that revert or hopefully a proper fix

@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@lpinca
Copy link
Copy Markdown
Member

lpinca commented Mar 30, 2026

We could revert only the Windows part but I guess it just complicates things.

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Mar 30, 2026

We could revert only the Windows part but I guess it just complicates things.

If the partial revert lands upstream, we could cherry-pick it

Copy link
Copy Markdown
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Mar 30, 2026

/cc @mcollina

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Mar 30, 2026

Looks like it didn't solve all the Windows flakiness:

---
duration_ms: 918.995
exitcode: 1
severity: fail
stack: |-
  [CLOSE] 3221226505 null
  node:internal/modules/run_main:107
      triggerUncaughtException(
      ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected

    {
  +   code: 3221226505,
  -   code: 0,
      signal: null,
      stderr: '',
  +   stdout: ''
  -   stdout: 'Hello world'
    }

      at checkProxied (d:\workspace\node-test-binary-windows-js-suites\node\test\common\proxy-server.js:166:10)
      at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
      at async file:///d:/workspace/node-test-binary-windows-js-suites/node/test/client-proxy/test-http-set-global-proxy-from-env-override-fetch.mjs:14:1 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: { stderr: '', stdout: '', code: 3221226505, signal: null },
    expected: { stderr: '', code: 0, signal: null, stdout: 'Hello world' },
    operator: 'deepStrictEqual',
    diff: 'simple'
  }

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2026
@nodejs-github-bot nodejs-github-bot merged commit 0474a27 into nodejs:main Mar 30, 2026
96 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 0474a27

@aduh95 aduh95 deleted the revert-libuv-commit branch March 30, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. fast-track PRs that do not need to wait for 72 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants