deps: libuv: revert 3a9a6e3e6b#62511
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 30, 2026
Merged
Conversation
This commit reverts "tcp: support customizing TCP_KEEPINTVL and TCP_KEEPCNT". Without this revert, we see a lot of flakyness on Windows CI.
Collaborator
|
Review requested:
|
lpinca
approved these changes
Mar 30, 2026
Contributor
Author
|
Adding dont-land labels for now, release lines are probably better off waiting for a new upstream release with either that revert or hopefully a proper fix |
RafaelGSS
approved these changes
Mar 30, 2026
Collaborator
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Member
|
We could revert only the Windows part but I guess it just complicates things. |
panva
approved these changes
Mar 30, 2026
Contributor
Author
If the partial revert lands upstream, we could cherry-pick it |
jasnell
approved these changes
Mar 30, 2026
Member
|
/cc @mcollina |
Contributor
Author
|
Looks like it didn't solve all the Windows flakiness: |
Collaborator
Collaborator
Collaborator
|
Landed in 0474a27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts "tcp: support customizing TCP_KEEPINTVL and TCP_KEEPCNT".
Without this revert, we see a lot of flakyness on Windows CI.
Refs: #62497 (comment)
Refs: libuv/libuv@3a9a6e3