Merged
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Apr 5, 2026
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Author
Collaborator
Author
Collaborator
Author
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/62595 ✔ Done loading data for nodejs/node/pull/62595 ----------------------------------- PR info ------------------------------------ Title deps: update ngtcp2 to 1.22.0 (#62595) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-ngtcp2 -> nodejs:main Labels author ready, needs-ci, quic, dependencies, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x Commits 1 - deps: update ngtcp2 to 1.22.0 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/62595 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62595 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 Apr 2026 00:57:46 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62595#pullrequestreview-4059581802 ✘ This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-06T10:24:28Z: https://ci.nodejs.org/job/node-test-pull-request/72506/ - Querying data for job/node-test-pull-request/72506/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/24059863239 |
RafaelGSS
approved these changes
Apr 8, 2026
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 586403f |
Member
|
This bump breaks building with Fails with: We are building that example code intentionally, it's used in the QUIC test suite, added in #59946. I'm not sure what the best fix is here - is it practical for us to upgrade to C++23 for this, or do we need a floating patch to preserve C++20 compatibility, or to pin/fork the example server & client from v1.21 or something? |
Member
|
This should not have been landed with that difference. For now, I think our only option is to disable building the ngtcp2 examples until we can identify a better approach |
Member
|
Specifically, we can't upgrade to C++23 for this one experimental feature. |
Member
|
In general, please do not land updates to ngtcp2 and nghttp3 without someone who is working on the quic work reviewing and signing off first. These updates can actively break/conflict with work in progress. |
Member
|
@jasnell Is there a GH team for quic that could be added to CODEOWNERS for those deps? It wouldn't block the updates from landing, but at least would ping collaborators on such a team for awareness. |
Member
There is (@nodejs/quic) I didn't realise this wasn't hooked up. I'll open a PR to update CODEOWNERS. EDIT: Done #62652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ngtcp2 to 1.22.0.