Skip to content

benchmark: fix typo in startup-cli-version comment#62716

Open
Rohan5commit wants to merge 1 commit intonodejs:mainfrom
Rohan5commit:docs/fix-indispensable-comment-20260413
Open

benchmark: fix typo in startup-cli-version comment#62716
Rohan5commit wants to merge 1 commit intonodejs:mainfrom
Rohan5commit:docs/fix-indispensable-comment-20260413

Conversation

@Rohan5commit
Copy link
Copy Markdown
Contributor

Fix a typo in a benchmark comment by changing indispensible to indispensable.

Related issue: N/A

Validation: not run; comment-only change.

Signed-off-by: Codex <codex@openai.com>
Copilot AI review requested due to automatic review settings April 13, 2026 02:14
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 13, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a spelling typo in a benchmark comment (indispensibleindispensable) in the CLI startup benchmark.

Changes:

  • Corrected a single-word typo in an inline comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2026
@Trott
Copy link
Copy Markdown
Member

Trott commented Apr 13, 2026

I don't follow things around here anywhere nearly as closely as I used to, so I'm not sure if this meets our sign-off criteria or not:

Signed-off-by: Codex codex@openai.com

@MikeMcC399
Copy link
Copy Markdown
Contributor

Also mentioned in #62577 (comment)

Only people can sign off. The Signed-off-by trailer should not be added by bots or AI-agents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants