Skip to content

[v24.x] src: allow empty --experimental-config-file#63659

Open
marco-ippolito wants to merge 3 commits into
nodejs:v24.x-stagingfrom
marco-ippolito:backport-stuff
Open

[v24.x] src: allow empty --experimental-config-file#63659
marco-ippolito wants to merge 3 commits into
nodejs:v24.x-stagingfrom
marco-ippolito:backport-stuff

Conversation

@marco-ippolito
Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/security-wg
  • @nodejs/startup
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 30, 2026
PR-URL: nodejs#60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#61610
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (b881658) to head (c28ce0d).
⚠️ Report is 66 commits behind head on v24.x-staging.

Files with missing lines Patch % Lines
src/node_config_file.cc 85.71% 3 Missing and 1 partial ⚠️
src/node.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #63659      +/-   ##
=================================================
+ Coverage          89.92%   89.95%   +0.03%     
=================================================
  Files                686      686              
  Lines             208389   208997     +608     
  Branches           40077    40185     +108     
=================================================
+ Hits              187387   187998     +611     
- Misses             13238    13239       +1     
+ Partials            7764     7760       -4     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 98.53% <100.00%> (+0.66%) ⬆️
lib/internal/test_runner/runner.js 93.70% <100.00%> (+0.51%) ⬆️
src/node_config_file.h 100.00% <100.00%> (ø)
src/node_options.cc 76.37% <100.00%> (+0.09%) ⬆️
src/node_options.h 97.90% <ø> (+0.02%) ⬆️
src/node.cc 74.57% <87.50%> (+0.13%) ⬆️
src/node_config_file.cc 81.53% <85.71%> (+0.76%) ⬆️

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants